Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue Multiple Paths Between IF/ELSE Branches #11646

Merged
merged 2 commits into from
Dec 23, 2024
Merged

fix: issue Multiple Paths Between IF/ELSE Branches #11646

merged 2 commits into from
Dec 23, 2024
+7 −4

Conversation

yihong0618
Copy link
Contributor

Summary

The logic steam answer is wrong we can not make sure which is the right answer.

close #11542 #9560 #10638 #10564,

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 13, 2024
This was referenced Dec 13, 2024
Closed
Open
@laipz8200
Copy link
Member

image

Hi, I tested this change in a simple chat flow and got a strange answer.

Here is the chat flow I used: Basic Chatflow.txt, you can copy its address and import it from the URL.

@yihong0618
Copy link
Contributor Author

let me fix it

@yihong0618
Copy link
Contributor Author

image Hi, I tested this change in a simple chat flow and got a strange answer.

Here is the chat flow I used: Basic Chatflow.txt, you can copy its address and import it from the URL.

try to fix it, can you test again

@laipz8200
Copy link
Member

I just changed the content in the Answer node, and the problem is still present.

image

@yihong0618 yihong0618 marked this pull request as draft December 15, 2024 09:17
@yihong0618
Copy link
Contributor Author

not quite the root cause its hard, so draft it for now

@yihong0618 yihong0618 marked this pull request as ready for review December 19, 2024 09:04
@yihong0618
Copy link
Contributor Author

not quite the root cause its hard, so draft it for now

root cause found

@laipz8200
Copy link
Member

After a few tests, it works well!

@yihong0618
Copy link
Contributor Author

After a few tests, it works well!

niubi a！

@laipz8200
Copy link
Member

Try this App: test_case.txt

test_case_screenshot

message:

hello, what's your name and what can you do for me?

Now the streaming output not work in Answer 2

@yihong0618
Copy link
Contributor Author

cool will test

@yihong0618
Copy link
Contributor Author

Try this App: test_case.txt

test_case_screenshot message:

hello, what's your name and what can you do for me?

Now the streaming output not work in Answer 2

it worked the same behavior as cloud

@yihong0618 yihong0618 mentioned this pull request Dec 20, 2024
Merged
5 tasks
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 23, 2024
@laipz8200 laipz8200 merged commit e0f1410 into langgenius:main Dec 23, 2024
5 checks passed
Scorpion1221 added a commit to yybht155/dify that referenced this pull request Dec 24, 2024
@Scorpion1221
Merge commit 'e88ea71aefd2adca64683ce0cca836df015d0f4f'
d26836d 
* commit 'e88ea71aefd2adca64683ce0cca836df015d0f4f': (91 commits)
  chore/bump version to 0.14.2 (langgenius#12017)
  fix: issue Multiple Paths Between IF/ELSE Branches (langgenius#11646)
  Fix/refactor invoke result handling in question classifier node (langgenius#12015)
  fix: remove json_schema if response format is disabled. (langgenius#12014)
  fix: add UUID validation for tool file ID extraction (langgenius#12011)
  fix: add logging for missing edge mapping in StreamProcessor (langgenius#12008)
  Fix/add retry mechanism to billing service request handling (langgenius#12006)
  Fix/workflow retry log (langgenius#12013)
  fix: add retry feature to code node (langgenius#12005)
  fix: drop useless and wrong code in Account (langgenius#11961)
  fix: improve error handling for file retrieval in AwsS3Storage (langgenius#12002)
  Fix/workflow retry (langgenius#11999)
  feat: add RequestBodyError for invalid request body handling (langgenius#11994)
  fix: Introduce ArrayVariable and update iteration node to handle it (langgenius#12001)
  fix: remove unused credential validation logic in VectorizerProvider (langgenius#12000)
  feat: Warning on invite modal when mail setup is incomplete (langgenius#11809)
  fix: handle broader request exceptions in OAuth process (langgenius#11997)
  fix: Multiple Paths Between IF/ELSE Branches Invalidate Conditions  (langgenius#11544)
  fix: retry node in iteration logs wrong (langgenius#11995)
  fix: remove the unused retry index field (langgenius#11903)
  ...

# Conflicts:
#	web/yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laipz8200 laipz8200 laipz8200 approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple Paths Between IF/ELSE Branches Invalidate Conditions and Execute All Paths
2 participants
@yihong0618 @laipz8200